ndimiduk commented on code in PR #6356:
URL: https://github.com/apache/hbase/pull/6356#discussion_r1799304662
##########
dev-support/hbase-personality.sh:
##########
@@ -233,8 +246,15 @@ function personality_modules
# tests respectively.
if [[ ${testtype} == unit ]]; then
local tests_arg=""
+
+ if [ -n "${TEST_PROFILE}" ]; then
+ extra="${extra} -P${TEST_PROFILE}"
+ else
+ extra="${extra} -PrunAllTests"
Review Comment:
nit: fold "runAllTests" in to a default value for this variable at
declaration time and then you can set `extra` unconditionally.
##########
dev-support/hbase-personality.sh:
##########
@@ -589,6 +609,7 @@ function hadoopcheck_rebuild
fi
if [[ "${PATCH_BRANCH}" = *"branch-2.5"* ]]; then
+ # TODO remove this on non 2.5 branches ?
yetus_info "Setting Hadoop 3 versions to test based on branch-2.5 rules"
if [[ "${QUICK_HADOOPCHECK}" == "true" ]]; then
hbase_hadoop3_versions="3.2.4 3.3.6 3.4.0"
Review Comment:
Should we keep these version number lists managed in a single place? I guess
that would be in the Jenkinsfile(s) (sob).
##########
dev-support/Jenkinsfile:
##########
@@ -153,35 +157,47 @@ pipeline {
}
}
stage ('hadoop 3 cache') {
- environment {
- HADOOP3_VERSION="3.3.5"
- }
steps {
- // directory must be unique for each parallel stage, because
jenkins runs them in the same workspace :(
- dir('downloads-hadoop-3') {
- sh '''#!/usr/bin/env bash
- echo "Make sure we have a directory for downloading
dependencies: $(pwd)"
+ script {
+ hadoop3_versions = env.HADOOP3_VERSIONS.split(",");
+ env.HADOOP3_VERSIONS_REGEX = "[" + hadoop3_versions.join("|") +
"]";
+ for (hadoop3_version in hadoop3_versions) {
+ env.HADOOP3_VERSION = hadoop3_version;
+ echo "env.HADOOP3_VERSION" + env.hadoop3_version;
+ stage ('Hadoop 3 cache inner stage') {
Review Comment:
Generating stages from a script. Ouch. Yeah, okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
