Apache9 commented on code in PR #6279:
URL: https://github.com/apache/hbase/pull/6279#discussion_r1777951871
##########
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java:
##########
@@ -2070,6 +2070,9 @@ private void
execCompletionCleanup(Procedure<TEnvironment> proc) {
// Catch NullPointerExceptions or similar errors...
LOG.error("CODE-BUG: uncatched runtime exception for procedure: " +
proc, e);
}
+ // call schedulers completion cleanup, we have some special clean up logic
in this method so if
+ // it throws any exceptions, we can not just ignore it, like the above
procedure's cleanup
+ scheduler.completionCleanup(proc);
Review Comment:
I think the intention for the old code is to catch the code bug and let the
procedure executor go on.
Since now the schelder.completionCleanup has important logic, if there are
errors we'd better throw them out and crash master, otherwise we may get some
hanging procedures for ever...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
