guluo2016 commented on code in PR #6279:
URL: https://github.com/apache/hbase/pull/6279#discussion_r1773141287
##########
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java:
##########
@@ -2070,6 +2070,9 @@ private void
execCompletionCleanup(Procedure<TEnvironment> proc) {
// Catch NullPointerExceptions or similar errors...
LOG.error("CODE-BUG: uncatched runtime exception for procedure: " +
proc, e);
}
+ // call schedulers completion cleanup, we have some special clean up logic
in this method so if
+ // it throws any exceptions, we can not just ignore it, like the above
procedure's cleanup
+ scheduler.completionCleanup(proc);
Review Comment:
```java
try {
scheduler.completionCleanup(proc);
} catch (Throwable e) {
// Catch NullPointerExceptions or similar errors...
LOG.error("CODE-BUG: uncatched runtime exception for completion cleanup:
{}", proc, e);
}
```
The code comments indicate that executing scheduler.completionCleanup(proc)
may throw exception,
Don't we need to deal with it in here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
