rmdmattingly commented on code in PR #6294:
URL: https://github.com/apache/hbase/pull/6294#discussion_r1774065699
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManifest.java:
##########
@@ -439,7 +440,7 @@ public BackupManifest(FileSystem fs, Path backupPath)
throws BackupException {
} catch (Exception e) {
throw new BackupException(e);
}
- this.backupImage = BackupImage.fromProto(proto);
+ this.backupImage = hydrateRootDir(BackupImage.fromProto(proto),
backupPath);
Review Comment:
This is the meat of the change. The other files are either tests, or some
refactoring to make testing easier. I've deployed this to a test environment
and validated that we can run a restore of a backup, even after it is
replicated to a secondary location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
