bbeaudreault commented on code in PR #5402:
URL: https://github.com/apache/hbase/pull/5402#discussion_r1330557899
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientScannerTimeouts.java:
##########
@@ -101,6 +102,9 @@ public static void setUpBeforeClass() throws Exception {
conf.setInt(HConstants.HBASE_CLIENT_SCANNER_TIMEOUT_PERIOD, scanTimeout);
conf.setInt(HBASE_CLIENT_META_READ_RPC_TIMEOUT_KEY, metaScanTimeout);
conf.setInt(HBASE_CLIENT_META_SCANNER_TIMEOUT, metaScanTimeout);
+ // set to true by default here. it only affects next() calls, and we'll
explicitly
+ // set it to false in one of the tests below to test legacy behavior for
next call
+ conf.setBoolean(HBASE_CLIENT_USE_SCANNER_TIMEOUT_FOR_NEXT_CALLS, true);
Review Comment:
Added parameterized
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientScannerTimeouts.java:
##########
@@ -174,18 +178,27 @@ public void
testRetryOutOfOrderScannerNextExceptionAsync() throws IOException {
* timed out next() call and mess up the test.
*/
@Test
- public void testNormalScanTimeoutOnNext() throws IOException {
+ public void testNormalScanTimeoutOnNextWithLegacyMode() throws IOException {
Review Comment:
Removed as part of the parameterized change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
