bbeaudreault commented on code in PR #5402: URL: https://github.com/apache/hbase/pull/5402#discussion_r1326202957
########## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java: ########## @@ -116,16 +117,15 @@ public ClientScanner(final Configuration conf, final Scan scan, final TableName this.connection = connection; this.pool = pool; this.primaryOperationTimeout = primaryOperationTimeout; - this.retries = conf.getInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, Review Comment: While I was here and needed a new config, I cleaned these up. Configuration getter calls introduce synchronization and parse cost, so it's better to use what we already parsed in ConnectionConfiguration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org