[
https://issues.apache.org/jira/browse/GUACAMOLE-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Libor Svehlak updated GUACAMOLE-1718:
-------------------------------------
Description:
Steps to reproduce:
{noformat}
tar -xzf guacamole-server-1.4.0.tar.gz
cd guacamole-server-1.4.0
./configure --with-libavformat=no
{noformat}
Output:
{noformat}
....
checking for ssize_t... yes
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for AVCODEC... no
./configure: line 15051: .: filename argument required
.: usage: . filename [arguments] {noformat}
Reason: There seems to be a typo in {{configure.ac}} file on the line 251 (line
14214 in generated {{configure}} script provided in the source package). There
is specified {{[].}} instead of the correct {{{}[],{}}}:
{noformat}
#
# libavformat
#
have_libavformat=disabled
AC_ARG_WITH([libavformat],
[AS_HELP_STRING([--with-libavformat],
[use libavformat when encoding video
@<:@default=check@:>@])],
[].
[with_libavformat=check])
if test "x$with_libavformat" != "xno"
then
have_libavformat=yes
PKG_CHECK_MODULES([AVFORMAT], [libavformat],, [have_libavformat=no]);
fi
{noformat}
Side question / suggestion for enhancement: Isn't there a build & test
infrastructure to test that at least specification of switches (combination of
switches) are not causing build errors? Due to large test space (amount of
switches and their values) it would be most probably impossible to test all
combinations nevertheless at least a basic check (e.g. nothing provided, all
switches provided with "no" value, etc.) can help to avoid such errors in the
future.
was:
Steps to reproduce:
{noformat}
tar -xzf guacamole-server-1.4.0.tar.gz
cd guacamole-server-1.4.0
./configure --with-libavformat=no
{noformat}
Output:
{noformat}
....
checking for ssize_t... yes
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for AVCODEC... no
./configure: line 15051: .: filename argument required
.: usage: . filename [arguments] {noformat}
Reason: There seems to be a typo in {{configure.ac}} file on the line 246 (line
14214 in generated {{configure}} script provided in the source package). There
is specified {{[].}} instead of the correct {{{}[],{}}}:
{noformat}
#
# libavformat
#
have_libavformat=disabled
AC_ARG_WITH([libavformat],
[AS_HELP_STRING([--with-libavformat],
[use libavformat when encoding video
@<:@default=check@:>@])],
[].
[with_libavformat=check])
if test "x$with_libavformat" != "xno"
then
have_libavformat=yes
PKG_CHECK_MODULES([AVFORMAT], [libavformat],, [have_libavformat=no]);
fi
{noformat}
Side question / suggestion for enhancement: Isn't there a build & test
infrastructure to test that at least specification of switches (combination of
switches) are not causing build errors? Due to large test space (amount of
switches and their values) it would be most probably impossible to test all
combinations nevertheless at least a basic check (e.g. nothing provided, all
switches provided with "no" value, etc.) can help to avoid such errors in the
future.
> Configure script fails when "--with-libavformat=no" is specified
> ----------------------------------------------------------------
>
> Key: GUACAMOLE-1718
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1718
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole
> Affects Versions: 1.5.3
> Reporter: Libor Svehlak
> Priority: Major
>
> Steps to reproduce:
> {noformat}
> tar -xzf guacamole-server-1.4.0.tar.gz
> cd guacamole-server-1.4.0
> ./configure --with-libavformat=no
> {noformat}
> Output:
> {noformat}
> ....
> checking for ssize_t... yes
> checking for pkg-config... /usr/bin/pkg-config
> checking pkg-config is at least version 0.9.0... yes
> checking for AVCODEC... no
> ./configure: line 15051: .: filename argument required
> .: usage: . filename [arguments] {noformat}
> Reason: There seems to be a typo in {{configure.ac}} file on the line 251
> (line 14214 in generated {{configure}} script provided in the source
> package). There is specified {{[].}} instead of the correct {{{}[],{}}}:
> {noformat}
> #
> # libavformat
> #
> have_libavformat=disabled
> AC_ARG_WITH([libavformat],
> [AS_HELP_STRING([--with-libavformat],
> [use libavformat when encoding video
> @<:@default=check@:>@])],
> [].
> [with_libavformat=check])
> if test "x$with_libavformat" != "xno"
> then
> have_libavformat=yes
> PKG_CHECK_MODULES([AVFORMAT], [libavformat],, [have_libavformat=no]);
> fi
> {noformat}
> Side question / suggestion for enhancement: Isn't there a build & test
> infrastructure to test that at least specification of switches (combination
> of switches) are not causing build errors? Due to large test space (amount of
> switches and their values) it would be most probably impossible to test all
> combinations nevertheless at least a basic check (e.g. nothing provided, all
> switches provided with "no" value, etc.) can help to avoid such errors in the
> future.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
