[
https://issues.apache.org/jira/browse/GEODE-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519038#comment-17519038
]
ASF subversion and git services commented on GEODE-9980:
--------------------------------------------------------
Commit 01a101c3e479a50b9cca26b8c836e7ba10d1a60c in geode's branch
refs/heads/support/1.13 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=01a101c3e4 ]
[1.13] GEODE-9980: Revert serialization filter changes from 1.13 (#7562)
* Revert "GEODE-9980: Improve error handling of serial filters (#7299)"
This reverts commit 240feb88cdfbc2db44bec28ff23b079dc07b0c41.
* Revert "GEODE-9758: Add internal serial filter API (#7217)"
This reverts commit 220ea534973edbb2643df6476e349d783b04b21e.
* Revert "GEODE-9879: Extract SystemProperty to geode-common (#7177)"
This reverts commit 06bb3a66125e0c9f8c5dbe7ee579e44d462d802d.
* Revert "GEODE-9758: Move ClassUtils to geode-common (#7166)"
This reverts commit 31810b5bd6fdd09b60890b427af60a9542bac954.
* Revert "GEODE-9758: Move SanctionedSerializables to filter package (#7165)"
This reverts commit 1c21af7561fc52ee771203c33d321124adbc4b25.
* Revert "GEODE-9817: Enable customized source set paths for ClassAnalysisRule
(#7121)"
This reverts commit 68e7d6e577ffc6c2b98d6611d05c6a6e98bd3358.
> Startup of Locator or Server should fail fast if
> geode.enableGlobalSerialFilter is enabled but fails configuration
> ------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-9980
> URL: https://issues.apache.org/jira/browse/GEODE-9980
> Project: Geode
> Issue Type: Bug
> Components: serialization
> Affects Versions: 1.15.0
> Reporter: Kirk Lund
> Assignee: Kirk Lund
> Priority: Major
> Labels: GeodeOperationAPI, blocks-1.15.0, pull-request-available
> Fix For: 1.12.10, 1.13.9, 1.14.5, 1.15.0
>
>
> The following error conditions need better handling which includes handling
> of all errors consistently and cause the startup of a Locator or Server to
> fail if it's unable to honor the setting of
> {{-Dgeode.enableGlobalSerialFilter=true}} for any reason. Currently, if
> {{-Dgeode.enableGlobalSerialFilter=true}} is specified but Geode is unable to
> create a global serial filter, then it will will log a warning and continue
> running. A user may easily miss that log statement and believe that the JVM
> is running with a properly configured serialization filter.
> 1) The user is trying to secure the JVM very thoroughly and accidentally
> specifies both {{-Djdk.serialFilter}} and
> {{-Dgeode.enableGlobalSerialFilter}}.
> 2) The user runs some non-Geode code in the same JVM that invokes
> {{ObjectInputFilter.Config.setFilter(...)}} directly.
> 3) The user is using a version of Java 8 prior to 8u121 (the release that
> first added {{sun.misc.ObjectInputFilter}}) and specifies
> {{-Dgeode.enableGlobalSerialFilter=true}}. Also, the same behavior occurs if
> they do NOT specify enabling that property.
> 4) {{LocatorLauncher}} or {{ServerLauncher}} is started in a JVM that has
> already created at least one {{ObjectInputStream}} which will cause
> {{ObjectInputFilter.Config.setFilter(...)}} to fail.
> 5) {{LocatorLauncher}} or {{ServerLauncher}} is started in a Java 8 JVM that
> is not based on OpenJDK (ie {{sun.misc.ObjectInputFilter}} does not exist).
> 6) {{LocatorLauncher}} or {{ServerLauncher}} is started in an unforeseen
> environment that causes invocation of
> {{ObjectInputFilter.Config.setFilter(...)}} via Java Reflection to throw
> {{IllegalAccessException}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
