[
https://issues.apache.org/jira/browse/GEODE-9980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519034#comment-17519034
]
ASF subversion and git services commented on GEODE-9980:
--------------------------------------------------------
Commit dc042f5f62453eea5e80e9407bee04bf861d568b in geode's branch
refs/heads/support/1.12 from Kirk Lund
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=dc042f5f62 ]
[1.12] GEODE-9980: Revert serialization filter changes from 1.12 (#7563)
* Revert "GEODE-9980: Improve error handling of serial filters (#7299)"
This reverts commit 75fa13675c320a465245a78f7a841d0016860fc9.
* Revert "GEODE-9758: Add internal serial filter API (#7217)"
This reverts commit 03fe0cb9734046a1c018501306c694e642f8ccdd.
* Revert "GEODE-9879: Extract SystemProperty to geode-common (#7177)"
This reverts commit b69ee52ee3e80b6a7d5ee8e22012c531eef65534.
* Revert "GEODE-9758: Move ClassUtils to geode-common (#7166)"
This reverts commit a9d5f0cf49d3986e5c27bdd9460b939305499e0c.
* Revert "GEODE-9758: Move SanctionedSerializables to filter package (#7165)"
This reverts commit 40037b4de64333452547cb203b0b6793c59d3f8f.
* Revert "GEODE-9817: Enable customized source set paths for ClassAnalysisRule
(#7121)"
This reverts commit e55fedbc478759052e13b6e3b837e1667b39d00f.
> Startup of Locator or Server should fail fast if
> geode.enableGlobalSerialFilter is enabled but fails configuration
> ------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-9980
> URL: https://issues.apache.org/jira/browse/GEODE-9980
> Project: Geode
> Issue Type: Bug
> Components: serialization
> Affects Versions: 1.15.0
> Reporter: Kirk Lund
> Assignee: Kirk Lund
> Priority: Major
> Labels: GeodeOperationAPI, blocks-1.15.0, pull-request-available
> Fix For: 1.12.10, 1.13.9, 1.14.5, 1.15.0
>
>
> The following error conditions need better handling which includes handling
> of all errors consistently and cause the startup of a Locator or Server to
> fail if it's unable to honor the setting of
> {{-Dgeode.enableGlobalSerialFilter=true}} for any reason. Currently, if
> {{-Dgeode.enableGlobalSerialFilter=true}} is specified but Geode is unable to
> create a global serial filter, then it will will log a warning and continue
> running. A user may easily miss that log statement and believe that the JVM
> is running with a properly configured serialization filter.
> 1) The user is trying to secure the JVM very thoroughly and accidentally
> specifies both {{-Djdk.serialFilter}} and
> {{-Dgeode.enableGlobalSerialFilter}}.
> 2) The user runs some non-Geode code in the same JVM that invokes
> {{ObjectInputFilter.Config.setFilter(...)}} directly.
> 3) The user is using a version of Java 8 prior to 8u121 (the release that
> first added {{sun.misc.ObjectInputFilter}}) and specifies
> {{-Dgeode.enableGlobalSerialFilter=true}}. Also, the same behavior occurs if
> they do NOT specify enabling that property.
> 4) {{LocatorLauncher}} or {{ServerLauncher}} is started in a JVM that has
> already created at least one {{ObjectInputStream}} which will cause
> {{ObjectInputFilter.Config.setFilter(...)}} to fail.
> 5) {{LocatorLauncher}} or {{ServerLauncher}} is started in a Java 8 JVM that
> is not based on OpenJDK (ie {{sun.misc.ObjectInputFilter}} does not exist).
> 6) {{LocatorLauncher}} or {{ServerLauncher}} is started in an unforeseen
> environment that causes invocation of
> {{ObjectInputFilter.Config.setFilter(...)}} via Java Reflection to throw
> {{IllegalAccessException}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
