[ 
https://issues.apache.org/jira/browse/GEODE-9536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426340#comment-17426340
 ] 

ASF subversion and git services commented on GEODE-9536:
--------------------------------------------------------

Commit 07c8ecb1fe0c2e4065d70356eebe0676f12bd83d in geode's branch 
refs/heads/develop from Dale Emery
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=07c8ecb ]

GEODE-9536: Make PingOp test more patient (#6951)

* GEODE-9536: Make PingOp test more patient

PROBLEM

On some versions of Windows (such as the version we use in CI), the
granularity of `System.currentTimeMillis()` is ~15ms.

`PingOpDistributedTest.regularPingFlow()` executes two pings and
asserts that the resulting heartbeat timestamp to has increased from one
ping to the next.

The test's two pings often occur so rapidly that the heartbeat
timestamps appear to be the same, causing the assertion to fail.

SOLUTION

Change the test to use `await()` to repeat the pings until the heartbeat
timestamp increases.

NOTE

This prepares for an upcoming PR to run all distributed tests on
Windows.

* Assert that heartbeat never decreases

> Run all Windows distributed tests in CI, in parallel
> ----------------------------------------------------
>
>                 Key: GEODE-9536
>                 URL: https://issues.apache.org/jira/browse/GEODE-9536
>             Project: Geode
>          Issue Type: Test
>          Components: ci, tests
>            Reporter: Dale Emery
>            Assignee: Dale Emery
>            Priority: Major
>              Labels: GeodeOperationAPI, pull-request-available
>
> Currently CI runs only a subset of distributed tests on Windows, and it runs 
> them sequentially.
> Change CI to run all distributed tests in Windows, and to run them in 
> parallel.
> This requires changing a small number tests to allow them to run on Windows. 
> It may require additional changes to allow them to run in parallel on Windows.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to