[
https://issues.apache.org/jira/browse/GEODE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389145#comment-17389145
]
ASF GitHub Bot commented on GEODE-9356:
---------------------------------------
pdxcodemonkey commented on a change in pull request #836:
URL: https://github.com/apache/geode-native/pull/836#discussion_r678736680
##########
File path: netcore/CMakeLists.txt
##########
@@ -0,0 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+project(netcore LANGUAGES NONE)
+
+add_custom_target(netcore ALL COMMAND dotnet build WORKING_DIRECTORY =
${CMAKE_CURRENT_SOURCE_DIR}/NetCore DEPENDS apache-geode VERBATIM)
Review comment:
>Just a runtime dependency. PInvoke code just says "look for this
function in apache-geode-c.DLL", build doesn't verify such a file exists or
anything. We could make it dependent in cmake, but I don't think we'll really
save anyone much time or trouble in the process. The entire .net core build is
< 5 seconds on my laptop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create CI pipeline for net-core
> -------------------------------
>
> Key: GEODE-9356
> URL: https://issues.apache.org/jira/browse/GEODE-9356
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: Ernest Burghardt
> Priority: Major
> Labels: pull-request-available
>
> This pipeline will be hosted on the Apache publicly available Concourse and
> publish to NuGet
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
