[ 
https://issues.apache.org/jira/browse/GEODE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383424#comment-17383424
 ] 

ASF GitHub Bot commented on GEODE-9431:
---------------------------------------

pivotal-jbarrett commented on a change in pull request #831:
URL: https://github.com/apache/geode-native/pull/831#discussion_r672432754



##########
File path: cppcache/test/ByteArrayFixture.cpp
##########
@@ -20,7 +20,7 @@
 ::testing::AssertionResult ByteArrayFixture::assertByteArrayEqual(
     const char* /*expectedStr*/, const char* /*bytesStr*/, const char* 
expected,
     const apache::geode::client::ByteArray& bytes) {
-  // One would normally just use std::regex but gcc 4.4.7 is lacking.
+  // One would normally just use boost::regex but gcc 4.4.7 is lacking.

Review comment:
       How about just resolving the issue in the comment. We don't support GCC 
4.4.7 anymore.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> CI Failure: SegFault in apache-geode_unittests
> ----------------------------------------------
>
>                 Key: GEODE-9431
>                 URL: https://issues.apache.org/jira/browse/GEODE-9431
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Kamilla Aslami
>            Priority: Major
>              Labels: pull-request-available
>
> {{Two consequent geode-native-develop/build-rhel-8-release runs failed with 
> segmentation fault: }}
> {noformat}
> selected worker: 3eb01fee-0959-4e2d-8c25-44a153962eaa
> Warning: Permanently added '34.67.7.72' (ECDSA) to the list of known hosts.
> Test project /home/build/build/cppcache/test
>     Start 1: apache-geode_unittests
> 1/1 Test #1: apache-geode_unittests ...........***Exception: SegFault  0.43 
> sec
> Running main() from 
> /home/build/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest_main.cc
> [==========] Running 374 tests from 42 test suites.
> [----------] Global test environment set-up.
> [----------] 6 tests from durationTest
> [ RUN      ] durationTest.ceil
> [       OK ] durationTest.ceil (0 ms)
> [ RUN      ] durationTest.toString
> [       OK ] durationTest.toString (0 ms)
> [ RUN      ] durationTest.fromString
> [       OK ] durationTest.fromString (0 ms)
> [ RUN      ] durationTest.fromStringWithCeil
> [       OK ] durationTest.fromStringWithCeil (0 ms)
> [ RUN      ] durationTest.fromStringException
> [       OK ] durationTest.fromStringException (0 ms)
> [ RUN      ] durationTest.assertBounds
> [       OK ] durationTest.assertBounds (1 ms)
> [----------] 6 tests from durationTest (1 ms total){noformat}
> ...
> {noformat}
> 0% tests passed, 1 tests failed out of 1
> Total Test time (real) =   0.91 sec
> The following tests FAILED:
>    1 - apache-geode_unittests (SEGFAULT)
> Errors while running CTest{noformat}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to