[ 
https://issues.apache.org/jira/browse/GEODE-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302929#comment-17302929
 ] 

ASF GitHub Bot commented on GEODE-8994:
---------------------------------------

pdxcodemonkey commented on pull request #768:
URL: https://github.com/apache/geode-native/pull/768#issuecomment-800640620


   Test issue seen with the prior fix is almost certainly due to the issue 
fixed in https://github.com/apache/geode-native/pull/762.  Closing this, and 
will rebase the earlier PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Log line for EventId ctor potentially contains garbage string
> -------------------------------------------------------------
>
>                 Key: GEODE-8994
>                 URL: https://issues.apache.org/jira/browse/GEODE-8994
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Blake Bender
>            Assignee: Blake Bender
>            Priority: Major
>              Labels: pull-request-available
>
> The following logging was recently added to geode-native for debugging:
> ```
> LOGDEBUG("EventId::EventId(%p) - memId=%s, memIdLen=%d, thr=%" PRId64
>  ", seq=%" PRId64, this, memId, memIdLen, thr, seq);
> ```
> The variable `memId` in this case is of type `char*` but is NOT a valid 
> string, rather just a byte buffer.  Logging it this way can potentially print 
> out garbage, causing errors in parsing tools like gnmsg or other apps when 
> attempting to read it.  `memId` needs to be decoded into a string 
> representation of the bytes, and that logged, rather than attempting to print 
> it out raw.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to