[ https://issues.apache.org/jira/browse/GEODE-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295610#comment-17295610 ]
ASF subversion and git services commented on GEODE-8994: -------------------------------------------------------- Commit 6f82926ea4f9fb1ede66b8c67e911a1c1c66aeb3 in geode-native's branch refs/heads/develop from Blake Bender [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=6f82926 ] GEODE-8994: Fix log line in EventId ctor (#756) - memId isn't a string, need to convert it first or we'll log garbage. > Log line for EventId ctor potentially contains garbage string > ------------------------------------------------------------- > > Key: GEODE-8994 > URL: https://issues.apache.org/jira/browse/GEODE-8994 > Project: Geode > Issue Type: Bug > Components: native client > Reporter: Blake Bender > Assignee: Blake Bender > Priority: Major > Labels: pull-request-available > > The following logging was recently added to geode-native for debugging: > ``` > LOGDEBUG("EventId::EventId(%p) - memId=%s, memIdLen=%d, thr=%" PRId64 > ", seq=%" PRId64, this, memId, memIdLen, thr, seq); > ``` > The variable `memId` in this case is of type `char*` but is NOT a valid > string, rather just a byte buffer. Logging it this way can potentially print > out garbage, causing errors in parsing tools like gnmsg or other apps when > attempting to read it. `memId` needs to be decoded into a string > representation of the bytes, and that logged, rather than attempting to print > it out raw. -- This message was sent by Atlassian Jira (v8.3.4#803005)