[
https://issues.apache.org/jira/browse/GEODE-8925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299022#comment-17299022
]
ASF GitHub Bot commented on GEODE-8925:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #760:
URL: https://github.com/apache/geode-native/pull/760#discussion_r591745678
##########
File path: cppcache/integration/test/PartitionRegionOpsTest.cpp
##########
@@ -191,74 +237,85 @@ void
getPartitionedRegionWithRedundancyServerGoesDown(bool singleHop) {
.execute();
auto cache = createCache();
- auto pool = createPool(cluster, cache, singleHop);
+ auto pool = createPool(cluster, cache, useSingleHop);
auto region = setupRegion(cache, pool);
- int ENTRIES = 30;
-
- putEntries(region, ENTRIES, 0);
+ int ENTRIES = 113;
- getEntries(region, ENTRIES);
+ putAllEntries(region, ENTRIES);
+ getAllEntries(region, ENTRIES);
cluster.getServers()[1].stop();
- getEntries(region, ENTRIES);
+ getAllEntries(region, ENTRIES);
cluster.getServers()[1].start();
- getEntries(region, ENTRIES);
+ getAllEntries(region, ENTRIES);
}
/**
* In this test case we verify that in a partition region with redundancy
- * when one server goes down, all gets are still served.
+ * when one server goes down, all puts and gets are still served.
+ *
* Single-hop is enabled in the client.
+ *
* It can be observed in the logs that when one of the server goes down
* the bucketServerLocations for that server are removed from the
* client metadata.
*/
-TEST(PartitionRegionOpsTest,
- getPartitionedRegionWithRedundancyServerGoesDownSingleHop) {
+TEST(PartitionRegionWithRedundancyTest, putgetWithSingleHop) {
removeLogFromPreviousExecution();
- getPartitionedRegionWithRedundancyServerGoesDown(true);
+ bool useSingleHop = true;
+ putget(useSingleHop);
verifyMetadataWasRemovedAtFirstError();
}
/**
* In this test case we verify that in a partition region with redundancy
- * when one server goes down, all puts are still served.
+ * when one server goes down, all putAlls and getAlls are still served.
+ *
* Single-hop is enabled in the client.
+ *
* It can be observed in the logs that when one of the server goes down
* the bucketServerLocations for that server are removed from the
* client metadata.
- * When the server is brought back again, the meta data is refreshed
- * after putting again values.
*/
-TEST(PartitionRegionOpsTest,
- putPartitionedRegionWithRedundancyServerGoesDownSingleHop) {
+TEST(PartitionRegionWithRedundancyTest, putAllgetAllWithSingleHop) {
removeLogFromPreviousExecution();
- putPartitionedRegionWithRedundancyServerGoesDown(true);
+ bool useSingleHop = true;
+ putAllgetAll(useSingleHop);
verifyMetadataWasRemovedAtFirstError();
}
/**
* In this test case we verify that in a partition region with redundancy
- * when one server goes down, all gets are still served.
+ * when one server goes down, all puts and gets are still served.
+ *
* Single hop is not enabled in the client.
+ *
+ * It can be observed in the logs that no metadata was requested.
*/
-TEST(PartitionRegionOpsTest,
- getPartitionedRegionWithRedundancyServerGoesDownNoSingleHop) {
- getPartitionedRegionWithRedundancyServerGoesDown(false);
+TEST(PartitionRegionWithRedundancyTest, putgetWithoutSingleHop) {
+ removeLogFromPreviousExecution();
+ bool useSingleHop = false;
+ putget(useSingleHop);
+ verifyNoMetaData();
}
/**
* In this test case we verify that in a partition region with redundancy
- * when one server goes down, all puts are still served.
- * Single-hop is not enabled in the client.
+ * when one server goes down, all putAlls and getAlls are still served.
+ *
+ * Single hop is not enabled in the client.
+ *
+ * It can be observed in the logs that no metadata was requested.
*/
-TEST(PartitionRegionOpsTest,
- putPartitionedRegionWithRedundancyServerGoesDownNoSingleHop) {
- putPartitionedRegionWithRedundancyServerGoesDown(false);
+TEST(PartitionRegionWithRedundancyTest, putAllgetAllWithoutSingleHop) {
+ removeLogFromPreviousExecution();
Review comment:
Why are logs involved here at all. Testing base on logs should be
avoided at all cost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Migrate old integration test testThinClientPRSingleHop to new test framework
> ----------------------------------------------------------------------------
>
> Key: GEODE-8925
> URL: https://issues.apache.org/jira/browse/GEODE-8925
> Project: Geode
> Issue Type: Sub-task
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> The following singleHop tests are marked Flaky. This ticket is to port these
> to the new framework.
> * testThinClientPRSingleHop
> * testThinClientPutAllPRSingleHop
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
