[
https://issues.apache.org/jira/browse/GEODE-8925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298422#comment-17298422
]
ASF GitHub Bot commented on GEODE-8925:
---------------------------------------
mmartell commented on a change in pull request #760:
URL: https://github.com/apache/geode-native/pull/760#discussion_r590819249
##########
File path: cppcache/integration/test/PartitionRegionOpsTest.cpp
##########
@@ -89,19 +89,36 @@ std::shared_ptr<Region> setupRegion(Cache& cache,
}
void putEntries(std::shared_ptr<Region> region, int numEntries,
- int offsetForValue) {
+ int offsetForValue, bool isAllOp) {
Review comment:
I agree isAllOp is confusing. I don't think doAllOperations is any
better. I think this is much better:
- putEntries(..., bool usePutAll)
- getEntries(..., bool useGetAll)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Migrate old integration test testThinClientPRSingleHop to new test framework
> ----------------------------------------------------------------------------
>
> Key: GEODE-8925
> URL: https://issues.apache.org/jira/browse/GEODE-8925
> Project: Geode
> Issue Type: Sub-task
> Components: native client
> Reporter: Michael Martell
> Priority: Major
> Labels: pull-request-available
>
> The following singleHop tests are marked Flaky. This ticket is to port these
> to the new framework.
> * testThinClientPRSingleHop
> * testThinClientPutAllPRSingleHop
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
