[
https://issues.apache.org/jira/browse/GEODE-8971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298249#comment-17298249
]
ASF GitHub Bot commented on GEODE-8971:
---------------------------------------
albertogpz commented on pull request #6052:
URL: https://github.com/apache/geode/pull/6052#issuecomment-794287751
> Quite a lot of changes here to clean up the code. I'm also concerned that
there's not enough test coverage for the changes in terms of possible failure
conditions, such as if two threads call `stop()` on the same gateway sender
within quick succession. More unit tests should also be added for the
new/modified behaviour.
Thanks a lot for your thorough review. Impressive, as usual.
I have added a couple of tests in `SerialGatewaySenderImplTest` and
`ParallelGatewalSenderImplTest`to verify that two threads calling `stop()` on
the same gateway sender within quick succession does not provoke any harm and
the `preStop` and `postStop` methods do their job.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Batches with incomplete transactions when stopping the gateway sender
> ---------------------------------------------------------------------
>
> Key: GEODE-8971
> URL: https://issues.apache.org/jira/browse/GEODE-8971
> Project: Geode
> Issue Type: Improvement
> Components: wan
> Affects Versions: 1.14.0
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
> Labels: pull-request-available
>
> When the gateway sender is stopped there is a high probability that batches
> with incomplete transactions are sent even if group-transaction-events is
> enabled.
> The reason is that once the stop command reaches the gateway sender, it
> immediately stops queueing events, and this could happen in the middle of
> receiving events for the same transaction. If this is the case, some events
> for the transaction may have reached the queue right before the stop command
> was received and the rest of events for that transaction would not make it to
> the queue (they would be dropped) because they arrived right after the stop
> command was received at the gateway sender.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
