[ 
https://issues.apache.org/jira/browse/GEODE-8971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306510#comment-17306510
 ] 

ASF subversion and git services commented on GEODE-8971:
--------------------------------------------------------

Commit 841fa06c7b34916c09df920b7029974a78255cd0 in geode's branch 
refs/heads/develop from Alberto Gomez
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=841fa06 ]

GEODE-8971: Add grace period when stopping gateway sender with group-… (#6052)

* GEODE-8971: Add grace period when stopping gateway sender with 
group-transaction-events enabled

When the gateway sender is stopped there is a high probability that batches with
incomplete transactions are sent even if group-transaction-events is enabled.

The reason is that once the stop command reaches the gateway sender, it 
immediately
stops queueing events, and this could happen in the middle of receiving events 
for the
same transaction. If this is the case, some events for the transaction may have
reached the queue right before the stop command was received and the rest of 
events
for that transaction would not make it to the queue (they would be dropped) 
because
they arrived right after the stop command was received at the gateway sender.

One way to solve this issue to allow for a grace period when the gateway sender
is stopped during which only events that belong to transactions already
in the queue are queued. Any other event received by the gateway sender
during this grace period would be dropped. After this grace period
the gateway sender will be effectively stopped.


> Batches with incomplete transactions when stopping the gateway sender
> ---------------------------------------------------------------------
>
>                 Key: GEODE-8971
>                 URL: https://issues.apache.org/jira/browse/GEODE-8971
>             Project: Geode
>          Issue Type: Improvement
>          Components: wan
>    Affects Versions: 1.14.0
>            Reporter: Alberto Gomez
>            Assignee: Alberto Gomez
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.15.0
>
>
> When the gateway sender is stopped there is a high probability that batches 
> with incomplete transactions are sent even if group-transaction-events is 
> enabled.
> The reason is that once the stop command reaches the gateway sender, it 
> immediately stops queueing events, and this could happen in the middle of 
> receiving events for the same transaction. If this is the case, some events 
> for the transaction may have reached the queue right before the stop command 
> was received and the rest of events for that transaction would not make it to 
> the queue (they would be dropped) because they arrived right after the stop 
> command was received at the gateway sender.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to