[
https://issues.apache.org/jira/browse/GEODE-8998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294870#comment-17294870
]
ASF GitHub Bot commented on GEODE-8998:
---------------------------------------
Bill commented on a change in pull request #6083:
URL: https://github.com/apache/geode/pull/6083#discussion_r586849213
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/monitoring/ThreadsMonitoringImplDummy.java
##########
@@ -32,9 +32,17 @@ public boolean startMonitor(Mode mode) {
@Override
public void endMonitor() {}
+ private static class DummyAbstractExecutor extends AbstractExecutor {
+ private static final DummyAbstractExecutor SINGLETON = new
DummyAbstractExecutor();
+
+ private DummyAbstractExecutor() {
+ super("dummyExecutorGroup", 0L);
Review comment:
From looking at other group names they are typically capitalized like
class names and don't end in the word `Group`. So I recommend:
`"DummyExecutor"`
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/monitoring/ThreadsMonitoringImplDummy.java
##########
@@ -32,9 +32,17 @@ public boolean startMonitor(Mode mode) {
@Override
public void endMonitor() {}
+ private static class DummyAbstractExecutor extends AbstractExecutor {
Review comment:
I think this new class is not meant to be subclassed so I recommend
removing `Abstract` from the name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> setting thread-monitoring-enabled to false causes NullPointerException
> ----------------------------------------------------------------------
>
> Key: GEODE-8998
> URL: https://issues.apache.org/jira/browse/GEODE-8998
> Project: Geode
> Issue Type: Bug
> Components: core
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
> Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> If you set the geode property thread-monitoring-enabled to false then any
> geode cluster messaging is broken. As cluster messages are read the p2p
> reader thread throws a NullPointerException.
> This bug was introduced in GEODE-8521 so it has not yet been released.
> I have a test that reproduces the NPE and this fix will be simple.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
