[
https://issues.apache.org/jira/browse/GEODE-8998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294782#comment-17294782
]
ASF GitHub Bot commented on GEODE-8998:
---------------------------------------
dschneider-pivotal opened a new pull request #6083:
URL: https://github.com/apache/geode/pull/6083
The P2PReaderExecutorGroup is now called directly since the p2p reader
always needs
a non-null instance. When thread monitoring is disabled, the p2p reader will
still call
suspend and resume even though the P2PReaderExecutorGroup is not being
monitored.
But these calls are very cheap so it is better to call them instead of doing
a bunch of
null checks.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> setting thread-monitoring-enabled to false causes NullPointerException
> ----------------------------------------------------------------------
>
> Key: GEODE-8998
> URL: https://issues.apache.org/jira/browse/GEODE-8998
> Project: Geode
> Issue Type: Bug
> Components: core
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
> Priority: Major
> Labels: GeodeOperationAPI
>
> If you set the geode property thread-monitoring-enabled to false then any
> geode cluster messaging is broken. As cluster messages are read the p2p
> reader thread throws a NullPointerException.
> This bug was introduced in GEODE-8521 so it has not yet been released.
> I have a test that reproduces the NPE and this fix will be simple.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
