[
https://issues.apache.org/jira/browse/GEODE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17289412#comment-17289412
]
ASF GitHub Bot commented on GEODE-8905:
---------------------------------------
kohlmu-pivotal commented on a change in pull request #5989:
URL: https://github.com/apache/geode/pull/5989#discussion_r581448170
##########
File path:
geode-deployment-legacy/src/main/java/org/apache/geode/deployment/impl/legacy/LegacyJarDeploymentService.java
##########
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.geode.deployment.impl.legacy;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Path;
+import java.time.Instant;
+import java.util.Collections;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.stream.Collectors;
+
+import org.apache.logging.log4j.Logger;
+
+import org.apache.geode.annotations.Experimental;
+import org.apache.geode.deployment.JarDeploymentService;
+import org.apache.geode.internal.DeployedJar;
+import org.apache.geode.internal.JarDeployer;
+import org.apache.geode.logging.internal.log4j.api.LogService;
+import org.apache.geode.management.configuration.Deployment;
+import org.apache.geode.services.result.ServiceResult;
+import org.apache.geode.services.result.impl.Failure;
+import org.apache.geode.services.result.impl.Success;
+
+/**
+ * Implementation of {@link JarDeploymentService} that encpsulates the
standard method of deploying
+ * jars by delegating to the {@link JarDeployer}.
+ *
+ * @since Geode 1.15
+ */
+@Experimental
+public class LegacyJarDeploymentService implements JarDeploymentService {
+
+ private static final Logger logger = LogService.getLogger();
+
+ private final Map<String, Deployment> deployments;
+ private JarDeployer jarDeployer;
Review comment:
Given the way the legacy works, this JarDeployer can be replaced with
another JarDeployer. Once again, we are just wrapping the existing legacy
approach with a service interface. We aren't changing how the existing code
works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Introduce JarDeploymentService
> ------------------------------
>
> Key: GEODE-8905
> URL: https://issues.apache.org/jira/browse/GEODE-8905
> Project: Geode
> Issue Type: Improvement
> Components: gfsh, management
> Reporter: Patrick Johnsn
> Priority: Major
> Labels: pull-request-available
>
> Introduce a JarDeploymentService interface that will allow us to interchange
> the current way of deploying jars with the new modular approach.
>
> There will be an implementation that delegates to the existing JarDeployer
> and will maintain current behavior.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
