[
https://issues.apache.org/jira/browse/GEODE-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286659#comment-17286659
]
ASF GitHub Bot commented on GEODE-8905:
---------------------------------------
DonalEvans commented on a change in pull request #5989:
URL: https://github.com/apache/geode/pull/5989#discussion_r578655302
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java
##########
@@ -94,26 +92,16 @@ public void
deployJarsReceivedFromClusterConfiguration(ConfigurationResponse res
.flatMap(Set::stream)
.collect(Collectors.toList());
- if (jarFileNames != null && !jarFileNames.isEmpty()) {
+ if (!jarFileNames.isEmpty()) {
logger.info("Got response with jars: {}",
jarFileNames.stream().collect(joining(",")));
Review comment:
This line can be replaced with `logger.info("Got response with jars:
{}", String.join(",", jarFileNames));`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Introduce JarDeploymentService
> ------------------------------
>
> Key: GEODE-8905
> URL: https://issues.apache.org/jira/browse/GEODE-8905
> Project: Geode
> Issue Type: Improvement
> Components: gfsh, management
> Reporter: Patrick Johnsn
> Priority: Major
> Labels: pull-request-available
>
> Introduce a JarDeploymentService interface that will allow us to interchange
> the current way of deploying jars with the new modular approach.
>
> There will be an implementation that delegates to the existing JarDeployer
> and will maintain current behavior.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
