[ https://issues.apache.org/jira/browse/GEODE-8864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282764#comment-17282764 ]
ASF GitHub Bot commented on GEODE-8864: --------------------------------------- jhutchison commented on a change in pull request #5954: URL: https://github.com/apache/geode/pull/5954#discussion_r574145466 ########## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/hash/RedisHashCommandsFunctionInvoker.java ########## @@ -106,9 +107,10 @@ public int hstrlen(ByteArrayWrapper key, ByteArrayWrapper field) { } @Override - public Pair<BigInteger, List<Object>> hscan(ByteArrayWrapper key, Pattern matchPattern, int count, + public Pair<BigInteger, List<Object>> hscan(UUID clientID, ByteArrayWrapper key, + Pattern matchPattern, int count, BigInteger cursor) { - return invokeCommandFunction(key, HSCAN, matchPattern, count, cursor); + return invokeCommandFunction(key, HSCAN, matchPattern, count, cursor, clientID); Review comment: good catch- thx ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > finish implementation of Redis HScan Command > -------------------------------------------- > > Key: GEODE-8864 > URL: https://issues.apache.org/jira/browse/GEODE-8864 > Project: Geode > Issue Type: New Feature > Components: redis > Reporter: John Hutchison > Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.3.4#803005)