[
https://issues.apache.org/jira/browse/GEODE-8864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273089#comment-17273089
]
ASF GitHub Bot commented on GEODE-8864:
---------------------------------------
jhutchison commented on a change in pull request #5954:
URL: https://github.com/apache/geode/pull/5954#discussion_r565554359
##########
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/hash/AbstractHScanIntegrationTest.java
##########
@@ -336,48 +418,31 @@ public void
givenMultipleCountsAndMatches_returnsEntriesMatchingLastMatchParamet
}
@Test
- public void givenNegativeCursor_returnsEntriesUsingAbsoluteValueOfCursor() {
+ public void should_notReturnValue_givenValueWasRemovedBeforeHSCANISCalled()
+ throws ExecutionException, InterruptedException {
+
Map<String, String> entryMap = new HashMap<>();
entryMap.put("1", "yellow");
- entryMap.put("2", "green");
- entryMap.put("3", "orange");
+ entryMap.put("12", "green");
+ entryMap.put("3", "grey");
jedis.hmset("colors", entryMap);
+ Future deleteFuture = doAsyncHdel("colors", "3");
+ deleteFuture.get();
Review comment:
so yeah, the point was actually to make sure that the hdel WAS
synchronous (had completed before the hscan started) . Switched to use a
geode awaitutility, I guess that is a little more straightforward. The test
itself seems a little obvious, I agree, but it's called out in the docs, so In
figured it was good to have a test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> finish implementation of Redis HScan Command
> --------------------------------------------
>
> Key: GEODE-8864
> URL: https://issues.apache.org/jira/browse/GEODE-8864
> Project: Geode
> Issue Type: New Feature
> Components: redis
> Reporter: John Hutchison
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
