[
https://issues.apache.org/jira/browse/GEODE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272379#comment-17272379
]
ASF GitHub Bot commented on GEODE-8870:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #5947:
URL: https://github.com/apache/geode/pull/5947#discussion_r564798634
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java
##########
@@ -177,20 +169,15 @@ protected boolean processQueryUsingParams(final Message
msg,
// Get the collection type (which includes the element type)
// (used to generate the appropriate instance on the client)
- collectionType = getCollectionType(selectResults);
- isStructs = collectionType.getElementType().isStructType();
+ CollectionType collectionType = getCollectionType(selectResults);
+ boolean isStructs = collectionType.getElementType().isStructType();
// Check if the Query is from CQ execution.
if (cqQuery != null) {
- // Check if the key can be sent to the client based on its version.
- sendCqResultsWithKey = sendCqResultsWithKey(servConn);
-
- if (sendCqResultsWithKey) {
- // Update the collection type to include key info.
- collectionType = new CollectionTypeImpl(Collection.class,
- new StructTypeImpl(new String[] {"key", "value"}));
- isStructs = collectionType.getElementType().isStructType();
- }
+ // Update the collection type to include key info.
Review comment:
Yes, the corresponding method `sendCqResultsWithKey()` would now always
return true. I refactored it out based on static analyzer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove obsolete version compatibility code
> ------------------------------------------
>
> Key: GEODE-8870
> URL: https://issues.apache.org/jira/browse/GEODE-8870
> Project: Geode
> Issue Type: Improvement
> Reporter: Jacob Barrett
> Assignee: Jacob Barrett
> Priority: Major
> Labels: pull-request-available
>
> As a followup to GEODE-8837 remove all obsolete backwards compatibility code.
> This ticket will catch all changes to remove the obsolete code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
