[
https://issues.apache.org/jira/browse/GEODE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272376#comment-17272376
]
ASF GitHub Bot commented on GEODE-8870:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #5947:
URL: https://github.com/apache/geode/pull/5947#discussion_r564796702
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java
##########
@@ -1347,14 +1304,10 @@ private static void handleRegEx(LocalRegion region,
String regex, InterestResult
*/
private static void handleRegExPR(final PartitionedRegion region, final
String regex,
final InterestResultPolicy policy, final ServerConnection servConn)
throws IOException {
- final List keyList = new ArrayList(MAXIMUM_CHUNK_SIZE);
+ final List<Object> keyList = new ArrayList<>(MAXIMUM_CHUNK_SIZE);
region.getKeysWithRegEx(regex, sendTombstonesInRIResults(servConn, policy),
- new PartitionedRegion.SetCollector() {
- @Override
- public void receiveSet(Set theSet) throws IOException {
- appendInterestResponseKeys(region, regex, theSet, keyList,
servConn);
- }
- });
+ theSet -> appendInterestResponseKeys(region, regex,
uncheckedCast(theSet), keyList,
Review comment:
Yes, IJ wants concise readable code. I subscribe to the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove obsolete version compatibility code
> ------------------------------------------
>
> Key: GEODE-8870
> URL: https://issues.apache.org/jira/browse/GEODE-8870
> Project: Geode
> Issue Type: Improvement
> Reporter: Jacob Barrett
> Assignee: Jacob Barrett
> Priority: Major
> Labels: pull-request-available
>
> As a followup to GEODE-8837 remove all obsolete backwards compatibility code.
> This ticket will catch all changes to remove the obsolete code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
