[
https://issues.apache.org/jira/browse/GEODE-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258583#comment-17258583
]
ASF subversion and git services commented on GEODE-8667:
--------------------------------------------------------
Commit 6202eceaa89038ce9326e5f518437a5ba1ed93ca in geode's branch
refs/heads/develop from Jianxia Chen
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6202ece ]
GEODE-8667: Duplicate online Oplog compaction after offline Oplog compaction
(#5689)
After offline compaction, the new Oplog totalCount is zero,
and totalLiveCount is greater than zero, there is no need for further
compaction during restart.
When Oplog totalCount is zero, and totalLiveCount is less than or equals to
zero,
which indicates an empty Oplog, then compaction is needed.
Update totalCount during recovery, if totalCount == 0 and totalLiveCount > 0,
which indicates offline
compaction is done for this Oplog. Update totalCount to the value of
totalLiveCount to avoid duplicate compaction.
> Duplicate online Oplog compaction after offline Oplog compaction
> ----------------------------------------------------------------
>
> Key: GEODE-8667
> URL: https://issues.apache.org/jira/browse/GEODE-8667
> Project: Geode
> Issue Type: Bug
> Reporter: Jianxia Chen
> Assignee: Jianxia Chen
> Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
> Fix For: 1.14.0
>
>
> Use `compact offline-disk-store` command to compact the Oplogs offline.
> Then restart the servers.
> The logs show OplogCompactor thread is compacting Oplogs again when
> restarting the servers, even though the Oplogs were just compacted offline.
> For example:
> ```
> [info 2020/10/27 16:32:22.534 PDT <Idle OplogCompactor1> tid=0x35] Recovered
> values for disk store DEFAULT with unique id
> 76393d3c-dd10-4b89-b655-821d37631774
> [info 2020/10/27 16:32:22.535 PDT <OplogCompactor DEFAULT for oplog oplog#2>
> tid=0x35] OplogCompactor for DEFAULT compaction oplog id(s): oplog#2
> [info 2020/10/27 16:32:22.537 PDT <OplogCompactor DEFAULT for oplog oplog#2>
> tid=0x35] compaction did 2 creates and updates in 2 ms
> [info 2020/10/27 16:32:22.537 PDT <Oplog Delete Task1> tid=0x36] Deleted
> oplog#2 crf for disk store DEFAULT.
> [info 2020/10/27 16:32:22.538 PDT <Oplog Delete Task1> tid=0x36] Deleted
> oplog#2 krf for disk store DEFAULT.
> [info 2020/10/27 16:32:22.538 PDT <Oplog Delete Task1> tid=0x36] Deleted
> oplog#2 drf for disk store DEFAULT.
> ```
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
