[
https://issues.apache.org/jira/browse/GEODE-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17236540#comment-17236540
]
ASF GitHub Bot commented on GEODE-8667:
---------------------------------------
jchen21 commented on pull request #5689:
URL: https://github.com/apache/geode/pull/5689#issuecomment-731472883
When compacting oplogs offline, it creates a new krf and persists
`totalCount` with `0` in Oplog constructor. Then live entries are copied from
old oplogs to the new oplog. `totalCount` of the new oplog is updated during
this process. However, the updated `totalCount` is not persisted. Its persisted
value is still `0`, although the oplog is non-empty after compaction.
During recovery, the value of `totalCount` is recovered from krf as `0`.
`totalLiveCount` is incremented as the oplog is recovered. `totalCount` remains
`0`. Therefore, if `totalCount` == 0 and `totalLiveCount` > 0, no compaction is
needed. Since this condition shows that offline compaction is just done before
recovery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Duplicate online Oplog compaction after offline Oplog compaction
> ----------------------------------------------------------------
>
> Key: GEODE-8667
> URL: https://issues.apache.org/jira/browse/GEODE-8667
> Project: Geode
> Issue Type: Bug
> Reporter: Jianxia Chen
> Assignee: Jianxia Chen
> Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> Use `compact offline-disk-store` command to compact the Oplogs offline.
> Then restart the servers.
> The logs show OplogCompactor thread is compacting Oplogs again when
> restarting the servers, even though the Oplogs were just compacted offline.
> For example:
> ```
> [info 2020/10/27 16:32:22.534 PDT <Idle OplogCompactor1> tid=0x35] Recovered
> values for disk store DEFAULT with unique id
> 76393d3c-dd10-4b89-b655-821d37631774
> [info 2020/10/27 16:32:22.535 PDT <OplogCompactor DEFAULT for oplog oplog#2>
> tid=0x35] OplogCompactor for DEFAULT compaction oplog id(s): oplog#2
> [info 2020/10/27 16:32:22.537 PDT <OplogCompactor DEFAULT for oplog oplog#2>
> tid=0x35] compaction did 2 creates and updates in 2 ms
> [info 2020/10/27 16:32:22.537 PDT <Oplog Delete Task1> tid=0x36] Deleted
> oplog#2 crf for disk store DEFAULT.
> [info 2020/10/27 16:32:22.538 PDT <Oplog Delete Task1> tid=0x36] Deleted
> oplog#2 krf for disk store DEFAULT.
> [info 2020/10/27 16:32:22.538 PDT <Oplog Delete Task1> tid=0x36] Deleted
> oplog#2 drf for disk store DEFAULT.
> ```
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
