[ 
https://issues.apache.org/jira/browse/GEODE-8754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243315#comment-17243315
 ] 

ASF GitHub Bot commented on GEODE-8754:
---------------------------------------

mmartell commented on a change in pull request #704:
URL: https://github.com/apache/geode-native/pull/704#discussion_r535384810



##########
File path: clicache/integration-test2/SerializationTests.cs
##########
@@ -510,5 +823,119 @@ public void PutGetCustomSerializableTypes()
                 cache.Close();
             }
         }
-    }
-}
+
+               [Fact]
+               public void CompositeClassWithClassAsKey()

Review comment:
       I agree we should have a separate ClassAsKey. It would only use 
ReadInternalObject if the class being used as the key had a member that was a 
container (i.e., list, vector, dictionary). I had it that way originally.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Deserialization Error in .NET DataInput::ReadObject
> ---------------------------------------------------
>
>                 Key: GEODE-8754
>                 URL: https://issues.apache.org/jira/browse/GEODE-8754
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Michael Martell
>            Priority: Major
>              Labels: pull-request-available
>
> Using the IDataSerializable interface for user defined .NET types sometimes 
> fails in a Release build. Specifically, the DataInput::ReadObject() function 
> may fail in a Release build. 
> Note: DataInput::ReadObject() never fails in a Debug build.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to