[ https://issues.apache.org/jira/browse/GEODE-8754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243299#comment-17243299 ]
ASF GitHub Bot commented on GEODE-8754: --------------------------------------- mmartell commented on a change in pull request #704: URL: https://github.com/apache/geode-native/pull/704#discussion_r535362988 ########## File path: tests/javaobject/cli/TestClassC.java ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package javaobject.cli; + +import java.util.*; +import java.io.*; +import org.apache.geode.*; +import org.apache.geode.cache.Declarable; + +public class TestClassC implements Declarable, Serializable, DataSerializable { + private String Color; + private String Make; + private int Year; + + static { + Instantiator.register(new Instantiator(javaobject.cli.TestClassC.class, (byte) 102) { + public DataSerializable newInstance() { + return new TestClassC(); + } + }); + } + + + +/* Review comment: Fixed dead code in TestClassB.java and TestClassA.java. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Deserialization Error in .NET DataInput::ReadObject > --------------------------------------------------- > > Key: GEODE-8754 > URL: https://issues.apache.org/jira/browse/GEODE-8754 > Project: Geode > Issue Type: Bug > Components: native client > Reporter: Michael Martell > Priority: Major > Labels: pull-request-available > > Using the IDataSerializable interface for user defined .NET types sometimes > fails in a Release build. Specifically, the DataInput::ReadObject() function > may fail in a Release build. > Note: DataInput::ReadObject() never fails in a Debug build. > -- This message was sent by Atlassian Jira (v8.3.4#803005)