[ 
https://issues.apache.org/jira/browse/GEODE-8745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17241723#comment-17241723
 ] 

ASF subversion and git services commented on GEODE-8745:
--------------------------------------------------------

Commit 888e4734ac532a4465e2818010c7983ee57009a2 in geode's branch 
refs/heads/develop from Nabarun Nag
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=888e473 ]

GEODE-8745: Closing the queue region when senders are stopped (#5770)

* cleanQueues are applicable only while using persistence
        * when we are closing the region, the disk files are not deleted.
        * hence the values will still be maintained on restart.
        * Advantage will be that we are creating the queue region and its cache 
listener together
        * previously the region was not closed and cache listener was attached 
using mutators.
        * this caused secondary events to be missed before the cache listener 
is activated

> Closing the region backing the queue when the serial gateway sender is 
> stopped.
> -------------------------------------------------------------------------------
>
>                 Key: GEODE-8745
>                 URL: https://issues.apache.org/jira/browse/GEODE-8745
>             Project: Geode
>          Issue Type: Task
>          Components: wan
>            Reporter: Nabarun Nag
>            Priority: Major
>              Labels: pull-request-available
>
> In the commit for GEODE-7458, when the sender is stopped, the region backing 
> the queues are no more closed, but just remove the cache listeners.
> This is causing a problem, as the regions continue to exist, it keeps on 
> storing entry events and hence the queue size never gets to zero.
> Also, as the region exists but before attaching the cache listener when 
> restarting the sender leads to entries being never removed from the 
> unprocessed event map.
>  
> As mention in the PR for GEODE-7458 - "This option is only applicable for 
> Gateway Senders with enabled persistence."
> Hence believe that it is ok to close the region as the disk files will still 
> be maintained. so when we restart the values can be obtained back from the 
> disk stores.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to