[
https://issues.apache.org/jira/browse/GEODE-8745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240928#comment-17240928
]
ASF GitHub Bot commented on GEODE-8745:
---------------------------------------
DonalEvans commented on a change in pull request #5770:
URL: https://github.com/apache/geode/pull/5770#discussion_r532787287
##########
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/SerialWANPersistenceEnabledGatewaySenderDUnitTest.java
##########
@@ -603,27 +605,32 @@ public void
testReplicatedRegionPersistentWanGateway_restartSenderWithCleanQueue
vm7.invoke(() ->
WANTestBase.createPersistentReplicatedRegion(getTestMethodName() + "_RR", "ln",
isOffHeap()));
+ vm4.invoke(() -> WANTestBase.pauseSender("ln"));
+ vm5.invoke(() -> WANTestBase.pauseSender("ln"));
+
vm4.invoke(() -> WANTestBase.doPuts(getTestMethodName() + "_RR", 1000));
logger.info("Completed puts in the region");
vm4.invoke(() -> WANTestBase.stopSender("ln"));
vm5.invoke(() -> WANTestBase.stopSender("ln"));
- logger.info("Stopped all the senders. ");
- // Create receiver on remote site
- createReceiverInVMs(vm2, vm3);
+ logger.info("Stopped all the senders. ");
Review comment:
Instead of using the logger in this test to track progress, you could
instead use the `invoke()` method signature that passes a String
description/name as the first parameter, which allows anyone debugging the test
to see when the invocation in question starts and finishes. Just personal
preference, but I think it makes things neater and provides a little more
information to anyone looking at the test output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Closing the region backing the queue when the serial gateway sender is
> stopped.
> -------------------------------------------------------------------------------
>
> Key: GEODE-8745
> URL: https://issues.apache.org/jira/browse/GEODE-8745
> Project: Geode
> Issue Type: Task
> Components: wan
> Reporter: Nabarun Nag
> Priority: Major
> Labels: pull-request-available
>
> In the commit for GEODE-7458, when the sender is stopped, the region backing
> the queues are no more closed, but just remove the cache listeners.
> This is causing a problem, as the regions continue to exist, it keeps on
> storing entry events and hence the queue size never gets to zero.
> Also, as the region exists but before attaching the cache listener when
> restarting the sender leads to entries being never removed from the
> unprocessed event map.
>
> As mention in the PR for GEODE-7458 - "This option is only applicable for
> Gateway Senders with enabled persistence."
> Hence believe that it is ok to close the region as the disk files will still
> be maintained. so when we restart the values can be obtained back from the
> disk stores.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
