[jira] [Commented] (GEODE-8693) C++ native client Function.execute() with onServers does not throw exception if one of the servers goes down while executing the function.

Thu, 19 Nov 2020 01:06:05 -0800 


    [ 
https://issues.apache.org/jira/browse/GEODE-8693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235288#comment-17235288
 ] 

ASF GitHub Bot commented on GEODE-8693:
---------------------------------------

codecov-io edited a comment on pull request #690:
URL: https://github.com/apache/geode-native/pull/690#issuecomment-728320149


   # [Codecov](https://codecov.io/gh/apache/geode-native/pull/690?src=pr&el=h1) 
Report
   > Merging 
[#690](https://codecov.io/gh/apache/geode-native/pull/690?src=pr&el=desc) 
(a24d8c3) into 
[develop](https://codecov.io/gh/apache/geode-native/commit/5c7d47d34c2b8a53874ec6f53e66c2290fd0427c?el=desc)
 (5c7d47d) will **decrease** coverage by `0.04%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/geode-native/pull/690/graphs/tree.svg?width=650&height=150&src=pr&token=plpAqoqGag)](https://codecov.io/gh/apache/geode-native/pull/690?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #690      +/-   ##
   ===========================================
   - Coverage    74.12%   74.07%   -0.05%     
   ===========================================
     Files          644      644              
     Lines        51187    51184       -3     
   ===========================================
   - Hits         37942    37916      -26     
   - Misses       13245    13268      +23     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/geode-native/pull/690?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[cppcache/src/CqQueryImpl.cpp](https://codecov.io/gh/apache/geode-native/pull/690/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NxUXVlcnlJbXBsLmNwcA==)
 | `56.37% <0.00%> (ø)` | |
   | 
[cppcache/src/ExecutionImpl.cpp](https://codecov.io/gh/apache/geode-native/pull/690/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0V4ZWN1dGlvbkltcGwuY3Bw)
 | `69.92% <28.57%> (+1.84%)` | :arrow_up: |
   | 
[cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/690/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw)
 | `77.72% <100.00%> (+1.23%)` | :arrow_up: |
   | 
[cppcache/src/ThinClientStickyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/690/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRTdGlja3lNYW5hZ2VyLmNwcA==)
 | `77.88% <0.00%> (-10.58%)` | :arrow_down: |
   | 
[cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/690/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==)
 | `54.27% <0.00%> (-2.39%)` | :arrow_down: |
   | 
[cppcache/src/TXCommitMessage.cpp](https://codecov.io/gh/apache/geode-native/pull/690/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RYQ29tbWl0TWVzc2FnZS5jcHA=)
 | `74.50% <0.00%> (-1.97%)` | :arrow_down: |
   | 
[cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/690/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw)
 | `72.48% <0.00%> (-1.26%)` | :arrow_down: |
   | 
[cppcache/src/ClientMetadataService.cpp](https://codecov.io/gh/apache/geode-native/pull/690/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhU2VydmljZS5jcHA=)
 | `61.78% <0.00%> (-1.15%)` | :arrow_down: |
   | 
[...tegration-test/testThinClientRemoteRegionQuery.cpp](https://codecov.io/gh/apache/geode-native/pull/690/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFJlbW90ZVJlZ2lvblF1ZXJ5LmNwcA==)
 | `82.33% <0.00%> (-1.13%)` | :arrow_down: |
   | 
[cppcache/src/Log.cpp](https://codecov.io/gh/apache/geode-native/pull/690/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0xvZy5jcHA=)
 | `56.50% <0.00%> (-0.98%)` | :arrow_down: |
   | ... and [5 
more](https://codecov.io/gh/apache/geode-native/pull/690/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/geode-native/pull/690?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/geode-native/pull/690?src=pr&el=footer). 
Last update 
[5c7d47d...a24d8c3](https://codecov.io/gh/apache/geode-native/pull/690?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> C++ native client Function.execute() with onServers does not throw exception 
> if one of the servers goes down while executing the function.
> ------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-8693
>                 URL: https://issues.apache.org/jira/browse/GEODE-8693
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Alberto Gomez
>            Assignee: Alberto Gomez
>            Priority: Major
>              Labels: pull-request-available
>
> According to the Apache Geode Native C++ API documentation, the 
> FunctionService.onServers() function will throw an Exception if one of the 
> servers goes down while dispatching or executing the function on the server.
> Nevertheless, currently no exception is thrown in that case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to