[jira] [Commented] (GEODE-8693) C++ native client Function.execute() with onServers does not throw exception if one of the servers goes down while executing the function.

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/GEODE-8693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233066#comment-17233066
 ] 

ASF GitHub Bot commented on GEODE-8693:
---------------------------------------

pdxcodemonkey commented on a change in pull request #690:
URL: https://github.com/apache/geode-native/pull/690#discussion_r524547942



##########
File path: cppcache/src/ExecutionImpl.cpp
##########
@@ -429,33 +429,20 @@ void ExecutionImpl::executeOnAllServers(const 
std::string& func,
   std::shared_ptr<CacheableString> exceptionPtr = nullptr;
   GfErrType err = tcrdm->sendRequestToAllServers(
       func.c_str(), getResult, timeout, m_args, m_rc, exceptionPtr);
-  if (exceptionPtr != nullptr && err != GF_NOERR) {
-    LOGDEBUG("Execute errorred: %d", err);
-    // throw FunctionExecutionException( "Execute: failed to execute function
-    // with server." );
-    if (err == GF_CACHESERVER_EXCEPTION) {
-      throw FunctionExecutionException(
-          "Execute: failed to execute function with server.");
-    } else {
-      throwExceptionIfError("Execute", err);
-    }
-  }
-
-  if (err == GF_AUTHENTICATION_FAILED_EXCEPTION ||
-      err == GF_NOT_AUTHORIZED_EXCEPTION ||
-      err == GF_AUTHENTICATION_REQUIRED_EXCEPTION) {
-    throwExceptionIfError("Execute", err);
-  }
 
   if (err != GF_NOERR) {
+    LOGDEBUG("Execute errorred: %d", err);

Review comment:
       Sorry to be "that guy" about grammar, but errorred isn't really a word.  
Should be "erred" or just avoid it altogether and use "failed".  Thx

##########
File path: cppcache/src/ExecutionImpl.cpp
##########
@@ -429,33 +429,20 @@ void ExecutionImpl::executeOnAllServers(const 
std::string& func,
   std::shared_ptr<CacheableString> exceptionPtr = nullptr;
   GfErrType err = tcrdm->sendRequestToAllServers(
       func.c_str(), getResult, timeout, m_args, m_rc, exceptionPtr);
-  if (exceptionPtr != nullptr && err != GF_NOERR) {
-    LOGDEBUG("Execute errorred: %d", err);
-    // throw FunctionExecutionException( "Execute: failed to execute function
-    // with server." );
-    if (err == GF_CACHESERVER_EXCEPTION) {
-      throw FunctionExecutionException(
-          "Execute: failed to execute function with server.");
-    } else {
-      throwExceptionIfError("Execute", err);
-    }
-  }
-
-  if (err == GF_AUTHENTICATION_FAILED_EXCEPTION ||
-      err == GF_NOT_AUTHORIZED_EXCEPTION ||
-      err == GF_AUTHENTICATION_REQUIRED_EXCEPTION) {
-    throwExceptionIfError("Execute", err);
-  }
 
   if (err != GF_NOERR) {
+    LOGDEBUG("Execute errorred: %d", err);

Review comment:
       Ugh, and it was even like this to begin with - yikes, sorry.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> C++ native client Function.execute() with onServers does not throw exception 
> if one of the servers goes down while executing the function.
> ------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-8693
>                 URL: https://issues.apache.org/jira/browse/GEODE-8693
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Alberto Gomez
>            Assignee: Alberto Gomez
>            Priority: Major
>              Labels: pull-request-available
>
> According to the Apache Geode Native C++ API documentation, the 
> FunctionService.onServers() function will throw an Exception if one of the 
> servers goes down while dispatching or executing the function on the server.
> Nevertheless, currently no exception is thrown in that case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)