[
https://issues.apache.org/jira/browse/GEODE-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227627#comment-17227627
]
ASF subversion and git services commented on GEODE-8688:
--------------------------------------------------------
Commit 5c7d47d34c2b8a53874ec6f53e66c2290fd0427c in geode-native's branch
refs/heads/develop from Alberto Gomez
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=5c7d47d ]
GEODE-8688: Fix flaky C++ native client integration tests (#686)
* GEODE-8688: Fix flaky C++ native client integration tests
The following integration test cases under
integration/test (new integration tests)
ar flaky (do not
fail normally when run locally but fail very often
when run in CI).
-
PartitionRegionOpsTest.getPartitionedRegionWithRedundancyServerGoesDownSingleHop
-
PartitionRegionOpsTest.putPartitionedRegionWithRedundancyServerGoesDownSingleHop
There were two reasons that can make them fail.
One of them is that sometimes the connections to the server have expired
before the server is restarted and therefore, when traffic is sent
to the restarted server, no errors are found. To fix this,
the pool configuration for the test client
has been changed so that connections do not expire.
The other reason is that sometimes the error in the connection is
found by the ping thread that is invoking the
ThinClientPoolDM::sendRequestToEP() method and in this method,
when the IO error or TIMEOUT error are encountered,
the endpoint is not removed from the metadata (by means of the
removeBucketServerLocation method).
The code has been updated to remove the metadata also in this
case.
With these two changes, the test cases are not flaky anymore.
> Flaxy C++ Native client integration test cases:
> PartitionRegionOpsTest.[get|put]PartitionedRegionWithRedundancyServerGoesDownSingleHop
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-8688
> URL: https://issues.apache.org/jira/browse/GEODE-8688
> Project: Geode
> Issue Type: Bug
> Components: native client
> Affects Versions: 1.13.0
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
> Labels: pull-request-available
>
> The following test cases for the C++ native client are flaky:
> PartitionRegionOpsTest.getPartitionedRegionWithRedundancyServerGoesDownSingleHop
> PartitionRegionOpsTest.putPartitionedRegionWithRedundancyServerGoesDownSingleHop
>
> They fail very often when run in CI although I have not seen them fail when
> executed manually.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
