[
https://issues.apache.org/jira/browse/GEODE-8688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227542#comment-17227542
]
ASF GitHub Bot commented on GEODE-8688:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #686:
URL: https://github.com/apache/geode-native/pull/686#discussion_r518904843
##########
File path: cppcache/integration/test/PartitionRegionOpsTest.cpp
##########
@@ -144,9 +146,9 @@ void verifyMetadataWasRemovedAtFirstError() {
}
}
}
- ASSERT_TRUE((timeoutErrors == metadataRemovedDueToTimeout) &&
- (ioErrors == metadataRemovedDueToIoErr) &&
- (metadataRemovedDueToTimeout != metadataRemovedDueToIoErr));
+ ASSERT_EQ(timeoutErrors, metadataRemovedDueToTimeout);
Review comment:
Alternatively, if you want to see the results of all three checks and
fail if any of them fail you can use `EXPECT_*` macros. There are also more
options for expecting and asserting in the `gmock` module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Flaxy C++ Native client integration test cases:
> PartitionRegionOpsTest.[get|put]PartitionedRegionWithRedundancyServerGoesDownSingleHop
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-8688
> URL: https://issues.apache.org/jira/browse/GEODE-8688
> Project: Geode
> Issue Type: Bug
> Components: native client
> Affects Versions: 1.13.0
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
> Labels: pull-request-available
>
> The following test cases for the C++ native client are flaky:
> PartitionRegionOpsTest.getPartitionedRegionWithRedundancyServerGoesDownSingleHop
> PartitionRegionOpsTest.putPartitionedRegionWithRedundancyServerGoesDownSingleHop
>
> They fail very often when run in CI although I have not seen them fail when
> executed manually.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
