[
https://issues.apache.org/jira/browse/GEODE-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222610#comment-17222610
]
Jianxia Chen commented on GEODE-8667:
-------------------------------------
Initial code analysis shows that offline disk store compaction calls
`PersistentOplogSet.recoverRegionsThatAreReady()` which then calls
`getAlreadyRecoveredOnce().set(true)`. However, since it is offline execution.
When the servers recover, the servers may not have the correct value set for
`getAlreadyRecoveredOnce()`. Therefore, `PersistentOplogSet.recoverOplogs()`
schedules the online compaction again by calling `parent.scheduleCompaction()`,
even though offline compaction is already done right before servers restart.
> Duplicate online Oplog compaction after offline Oplog compaction
> ----------------------------------------------------------------
>
> Key: GEODE-8667
> URL: https://issues.apache.org/jira/browse/GEODE-8667
> Project: Geode
> Issue Type: Bug
> Reporter: Jianxia Chen
> Assignee: Jianxia Chen
> Priority: Major
> Labels: GeodeOperationAPI
>
> Use `compact offline-disk-store` command to compact the Oplogs offline.
> Then restart the servers.
> The logs show OplogCompactor thread is compacting Oplogs again when
> restarting the servers, even though the Oplogs were just compacted offline.
> For example:
> ```
> [info 2020/10/27 16:32:22.534 PDT <Idle OplogCompactor1> tid=0x35] Recovered
> values for disk store DEFAULT with unique id
> 76393d3c-dd10-4b89-b655-821d37631774
> [info 2020/10/27 16:32:22.535 PDT <OplogCompactor DEFAULT for oplog oplog#2>
> tid=0x35] OplogCompactor for DEFAULT compaction oplog id(s): oplog#2
> [info 2020/10/27 16:32:22.537 PDT <OplogCompactor DEFAULT for oplog oplog#2>
> tid=0x35] compaction did 2 creates and updates in 2 ms
> [info 2020/10/27 16:32:22.537 PDT <Oplog Delete Task1> tid=0x36] Deleted
> oplog#2 crf for disk store DEFAULT.
> [info 2020/10/27 16:32:22.538 PDT <Oplog Delete Task1> tid=0x36] Deleted
> oplog#2 krf for disk store DEFAULT.
> [info 2020/10/27 16:32:22.538 PDT <Oplog Delete Task1> tid=0x36] Deleted
> oplog#2 drf for disk store DEFAULT.
> ```
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
