[
https://issues.apache.org/jira/browse/GEODE-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216857#comment-17216857
]
ASF GitHub Bot commented on GEODE-8627:
---------------------------------------
sabbey37 commented on a change in pull request #5639:
URL: https://github.com/apache/geode/pull/5639#discussion_r507884986
##########
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/pubsub/AbstractSubscriptionsIntegrationTest.java
##########
@@ -88,18 +111,91 @@ public void multiSubscribe() {
.untilAsserted(() ->
assertThat(mockSubscriber.getReceivedPMessages()).hasSize(1));
assertThat(mockSubscriber.getReceivedEvents()).containsExactly("message",
"pmessage");
mockSubscriber.unsubscribe();
- client.close();
}
@Test
- public void unallowedCommandsWhileSubscribed() {
- Jedis client = new Jedis("localhost", getPort());
+ public void
unsubscribingImplicitlyFromAllChannels_doesNotUnsubscribeFromPatterns() {
Review comment:
We do have a test that only subscribes to channels and then unsubscribes
without an argument. We did not have a test that subscribes to channels and
psubscribes to patterns, then unsubscribes without an argument (or
punsubscribes without an argument). We were incorrectly unsubscribing from
everything (channels and patterns) when punsubscribe or unsubscribe were called
without an argument. Native Redis will only unsubscribe from channels (not
patterns) if unsubscribe is called without an argument or punsubscribe only
from patterns (not channels) if punsubscribe is called without an argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis not unsubscribing and punsubscribing correctly when no channel/pattern
> provided
> -------------------------------------------------------------------------------------
>
> Key: GEODE-8627
> URL: https://issues.apache.org/jira/browse/GEODE-8627
> Project: Geode
> Issue Type: Bug
> Components: redis
> Reporter: Sarah Abbey
> Assignee: Sarah Abbey
> Priority: Major
> Labels: pull-request-available
>
> Geode Redis should unsubscribe from all channels (not including patterns)
> when no channel is provided and punsubscribe from all patterns (not including
> channels) when no pattern is provided.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
