[
https://issues.apache.org/jira/browse/GEODE-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216767#comment-17216767
]
ASF GitHub Bot commented on GEODE-8627:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #5639:
URL: https://github.com/apache/geode/pull/5639#discussion_r507793073
##########
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/pubsub/AbstractSubscriptionsIntegrationTest.java
##########
@@ -88,18 +111,91 @@ public void multiSubscribe() {
.untilAsserted(() ->
assertThat(mockSubscriber.getReceivedPMessages()).hasSize(1));
assertThat(mockSubscriber.getReceivedEvents()).containsExactly("message",
"pmessage");
mockSubscriber.unsubscribe();
- client.close();
}
@Test
- public void unallowedCommandsWhileSubscribed() {
- Jedis client = new Jedis("localhost", getPort());
+ public void
unsubscribingImplicitlyFromAllChannels_doesNotUnsubscribeFromPatterns() {
Review comment:
Do we not already have similar tests in `AbstractPubSubIntegrationTest`?
Perhaps `testUnsubscribingImplicitlyFromAllChannels` and
`testPunsubscribingImplicitlyFromAllChannels`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redis not unsubscribing and punsubscribing correctly when no channel/pattern
> provided
> -------------------------------------------------------------------------------------
>
> Key: GEODE-8627
> URL: https://issues.apache.org/jira/browse/GEODE-8627
> Project: Geode
> Issue Type: Bug
> Components: redis
> Reporter: Sarah Abbey
> Assignee: Sarah Abbey
> Priority: Major
> Labels: pull-request-available
>
> Geode Redis should unsubscribe from all channels (not including patterns)
> when no channel is provided and punsubscribe from all patterns (not including
> channels) when no pattern is provided.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
