[ https://issues.apache.org/jira/browse/GEODE-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213287#comment-17213287 ]
ASF subversion and git services commented on GEODE-8512: -------------------------------------------------------- Commit 7c30a8cdbf4de1d7ae34309f5094dea261a8ce1e in geode-native's branch refs/heads/develop from Mario Salazar de Torres [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=7c30a8c ] GEODE-8512: Add expectDomainClass for PdxInstance (#661) - In Java client you can specify whether or not the PdxInstance you are trying to create when calling createPdxInstanceFactory represnets a Java domain class. - This commit adds the possibility to also specify expectDomainClass for the native C++ client. - Take into account that this is necessary in order to query PdxInstance entries which classname is __GEMFIRE_JSON with Gfsh tool. - Fix doxygen comments for old createPdxInstanceFactory overloads. - Modified Gfsh utilities from the testing framework to allow executing queries. - Added integration test in which is test the functionality. - Removed CacheImpl::createPdxInstanceFactory overload with a single parameter as there is no need for it anymore. - Inverted semantics of m_noJavaClass in PdxType so logic is more clear. - Added QueryFunction server function in order to further use it in testing, Such function allows the user to make a query from the server side. - Minor changes done to PdxTypeTest unit-test TS so ByteArray gtest expectations can be used. - Added unit-tests to verify serialization is properly done with the is_java_class_ attribute. - Added unit-tests to verify de-serialization is properly done with the is_java_class_ attribute. - Changed the integration test so it uses a server function instead of calling gfsh with a command. - Reversed changes that added the capability for Gfsh interface to execute queries as it is not needed anymore. - Fixed Cluster class so now it's possible to specify a single CacheXmlFile entry. - Added a resource folder for the new integration tests. Before resources were taken from the resources folder of the old testing framework. - Added a new entry in TestConfig so the above mentioned folder path can be accesed in the tests. - Added pdxjson_cacheserver.xml in the new integration test resource folder. > Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory > ---------------------------------------------------------------------------- > > Key: GEODE-8512 > URL: https://issues.apache.org/jira/browse/GEODE-8512 > Project: Geode > Issue Type: Improvement > Components: native client > Affects Versions: 1.13.0 > Reporter: Mario Salazar de Torres > Assignee: Mario Salazar de Torres > Priority: Minor > Labels: JsonFormatter, pull-request-available > > Within Java client, you can specify if the PdxInstance you want to create is > a Java domain class or not, but this is not the case for geode-native C++ > client. > Thing is that in order to implement JsonFormatter in C++ client, having this > change is mandatory, otherwise creating PdxType's with __GEMFIRE_JSON > classname will present some issues while using cquery's. > -- This message was sent by Atlassian Jira (v8.3.4#803005)