[
https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209895#comment-17209895
]
ASF GitHub Bot commented on GEODE-8583:
---------------------------------------
dschneider-pivotal commented on a change in pull request #5604:
URL: https://github.com/apache/geode/pull/5604#discussion_r501336900
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java
##########
@@ -93,13 +86,21 @@ public GeodeRedisServer(String bindAddress, int port,
InternalCache cache) {
CommandFunction.register(regionProvider.getDataRegion(), stripedExecutor,
redisStats);
RenameFunction.register(regionProvider.getDataRegion(), stripedExecutor,
redisStats);
RedisCommandFunction.register();
+
passiveExpirationManager =
new PassiveExpirationManager(regionProvider.getDataRegion(),
redisStats);
- redisCommandExecutor =
LoggingExecutors.newCachedThreadPool("GeodeRedisServer-Command-", true);
- nettyRedisServer = new NettyRedisServer(() ->
cache.getInternalDistributedSystem().getConfig(),
- regionProvider, pubSub,
- this::allowUnsupportedCommands, this::shutdown, port, bindAddress,
redisStats,
- redisCommandExecutor);
+ redisCommandExecutor =
+ LoggingExecutors.newCachedThreadPool("Redis Command", true);
Review comment:
This is an example of why it is better not to change a bunch of
formatting. Just let spotless do the formatting. In this case I think you
accidently lost a change to the thread name. Someone else changed it to
"GeodeRedisServer-Command-" and I think you lost that and reverted to back to
"Redis Command". You should have had a conflict but when you have changed a
bunch of formatting it can be hard for you to see things like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> create RestrictedInputValuesParameterRequirements in Redis Module
> -----------------------------------------------------------------
>
> Key: GEODE-8583
> URL: https://issues.apache.org/jira/browse/GEODE-8583
> Project: Geode
> Issue Type: Improvement
> Reporter: John Hutchison
> Priority: Minor
> Labels: pull-request-available, redis
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
