[
https://issues.apache.org/jira/browse/GEODE-8504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200541#comment-17200541
]
ASF GitHub Bot commented on GEODE-8504:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #5526:
URL: https://github.com/apache/geode/pull/5526#discussion_r492343203
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/netty/Command.java
##########
@@ -183,8 +184,16 @@ public boolean isOfType(RedisCommandType type) {
}
public String wrongNumberOfArgumentsError() {
- return String.format("wrong number of arguments for '%s' command",
- getCommandType().toString().toLowerCase());
+ String result;
+
+ if (getCommandType().equals(RedisCommandType.INFO)) {
Review comment:
Maybe a nit, but it feels like this is now hidden in a class that is
unrelated to anything about parameters. I much preferred your previous idea
about passing the 'special' error message in at the constraint level - i.e. in
`RedisCommandType`. Perhaps too much refactoring, but also consider making
`ParameterRequirements` abstract and pulling this method into that class. It
feels like a more natural place for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> implement (but not support) Redis Info command
> -----------------------------------------------
>
> Key: GEODE-8504
> URL: https://issues.apache.org/jira/browse/GEODE-8504
> Project: Geode
> Issue Type: Improvement
> Reporter: John Hutchison
> Assignee: Darrel Schneider
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> create no-ops command to support apps using this command
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
