[
https://issues.apache.org/jira/browse/GEODE-8504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199461#comment-17199461
]
ASF GitHub Bot commented on GEODE-8504:
---------------------------------------
jhutchison commented on a change in pull request #5526:
URL: https://github.com/apache/geode/pull/5526#discussion_r492162274
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/executor/server/InfoExecutor.java
##########
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.executor.server;
+
+import java.util.List;
+
+import
org.apache.geode.redis.internal.ParameterRequirements.RedisParametersMismatchException;
+import org.apache.geode.redis.internal.RedisConstants;
+import org.apache.geode.redis.internal.data.ByteArrayWrapper;
+import org.apache.geode.redis.internal.executor.AbstractExecutor;
+import org.apache.geode.redis.internal.executor.RedisResponse;
+import org.apache.geode.redis.internal.netty.Command;
+import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
+
+public class InfoExecutor extends AbstractExecutor {
+
+ @Override
+ public RedisResponse executeCommand(Command command,
+ ExecutionHandlerContext context) {
+ String result;
+ List<ByteArrayWrapper> commands =
+ command.getProcessedCommandWrappers();
+
+ if (containsTooManyParameters(commands)) {
Review comment:
as per discussion- will create a flavor of ParameterRequirements that
allows for mesg parameter (the reason we did this to begin with)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> implement (but not support) Redis Info command
> -----------------------------------------------
>
> Key: GEODE-8504
> URL: https://issues.apache.org/jira/browse/GEODE-8504
> Project: Geode
> Issue Type: Improvement
> Reporter: John Hutchison
> Priority: Major
> Labels: pull-request-available
>
> create no-ops command to support apps using this command
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
