[ https://issues.apache.org/jira/browse/GEODE-8480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193759#comment-17193759 ]
ASF GitHub Bot commented on GEODE-8480: --------------------------------------- pdxcodemonkey commented on pull request #648: URL: https://github.com/apache/geode-native/pull/648#issuecomment-690540485 Did you find an issue that was fixed by this? What is the repro case? Can we add a simple test that shows the problem? The changes look fine, but it's difficult to judge correctness or whether there's a product issue since it doesn't modify any product code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add tx manager check in geode-native transaction example > -------------------------------------------------------- > > Key: GEODE-8480 > URL: https://issues.apache.org/jira/browse/GEODE-8480 > Project: Geode > Issue Type: Improvement > Components: docs, native client > Reporter: Alberto Bustamante Reyes > Assignee: Alberto Bustamante Reyes > Priority: Minor > Labels: pull-request-available > > Transactions documentation & example in the geode C++ client is not checking > if the transaction manager exists before calling to rollback, as it is done > in the transactions documentation and example in geode. > I have seen that depending on the exception, the rollback can generate an > error so I think its something that should be added to the example. -- This message was sent by Atlassian Jira (v8.3.4#803005)