[jira] [Commented] (GEODE-8340) Enforce Switch compiler warnings as errors

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/GEODE-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173416#comment-17173416
 ] 

ASF GitHub Bot commented on GEODE-8340:
---------------------------------------

moleske commented on a change in pull request #625:
URL: https://github.com/apache/geode-native/pull/625#discussion_r467223869



##########
File path: cppcache/src/ExceptionTypes.cpp
##########
@@ -297,7 +297,25 @@ const std::string& getThreadLocalExceptionMessage();
       PutAllPartialResultException ex(message);
       throw ex;
     }
-    default: {
+    case GF_NOERR:

Review comment:
       
![pdxcodemonkey?](http://media2.giphy.com/gifsu/1qbj0e6kDAjS7elwu0/giphy-caption.gif?cid=6104955e5f2b035851577a4b4d4cc90a)
   
   (I mostly just wanted to post that gif, no particular rush 😃)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enforce Switch compiler warnings as errors
> ------------------------------------------
>
>                 Key: GEODE-8340
>                 URL: https://issues.apache.org/jira/browse/GEODE-8340
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Michael Oleske
>            Priority: Major
>              Labels: pull-request-available
>
> Given I compile the code without exempting no-switch-enum and 
> no-implicit-fallthrough and no-covered-switch-default
> Then it should compile
> Note - was marked as a todo, seems reasonable to tackle all these at once



--
This message was sent by Atlassian Jira
(v8.3.4#803005)