[
https://issues.apache.org/jira/browse/GEODE-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156878#comment-17156878
]
ASF GitHub Bot commented on GEODE-8340:
---------------------------------------
moleske commented on a change in pull request #625:
URL: https://github.com/apache/geode-native/pull/625#discussion_r453770010
##########
File path: cppcache/src/TcrMessage.cpp
##########
@@ -1015,6 +1015,36 @@ void TcrMessage::processChunk(const
std::vector<uint8_t>& chunk, int32_t len,
break;
}
// fall-through for other cases
+ if (m_chunkedResult != nullptr) {
Review comment:
The previous code did a fallthrough if it didn't make it to the `break;`
statement on line 999 or 1015 (which is buried in an `if` and `else if`). This
is the same code as on line 1054. I thought about extracting a function but
got lazy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enforce Switch compiler warnings as errors
> ------------------------------------------
>
> Key: GEODE-8340
> URL: https://issues.apache.org/jira/browse/GEODE-8340
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Oleske
> Priority: Major
>
> Given I compile the code without exempting no-switch-enum and
> no-implicit-fallthrough and no-covered-switch-default
> Then it should compile
> Note - was marked as a todo, seems reasonable to tackle all these at once
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
