[
https://issues.apache.org/jira/browse/GEODE-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140029#comment-17140029
]
ASF GitHub Bot commented on GEODE-8272:
---------------------------------------
DonalEvans commented on a change in pull request #5249:
URL: https://github.com/apache/geode/pull/5249#discussion_r442536212
##########
File path:
geode-management/src/main/java/org/apache/geode/management/runtime/RestoreRedundancyResults.java
##########
@@ -18,28 +18,28 @@
import java.util.List;
import java.util.Map;
+import org.apache.geode.annotations.Experimental;
+
/**
* A class to collect the results of restore redundancy operations for one or
more regions and
* determine the success of failure of the operation.
*/
+@Experimental
public interface RestoreRedundancyResults extends OperationResult {
/**
* {@link #SUCCESS} is defined as every included region having fully
satisfied redundancy.
* {@link #FAILURE} is defined as at least one region that is configured to
have redundant copies
* having fewer than its configured number of redundant copies.
- * {@link #ERROR} is for cases when the restore redundancy operation was
unable to begin or threw
- * an exception.
*/
enum Status {
SUCCESS,
- FAILURE,
- ERROR
Review comment:
You're correct, this was originally intended to be a way to capture the
case that an exception was thrown during the `doRestoreRedundancy()` method in
`RestoreRedundancyOperationImpl`, but in order to keep the implementation as
similar to that found in `RebalanceOperationImpl` as possible, this was not
implemented. It should be fine to remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor GFSH Restore Redundancy Command code to allow for REST API
> -------------------------------------------------------------------
>
> Key: GEODE-8272
> URL: https://issues.apache.org/jira/browse/GEODE-8272
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Mark Hanson
> Assignee: Mark Hanson
> Priority: Major
>
> Refactor GFSH Restore Redundancy Command code to allow for REST API
>
> The core code path is specific to GFSH right now and needs a few changes to
> support the REST API command.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
