[
https://issues.apache.org/jira/browse/GEODE-8272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140013#comment-17140013
]
ASF GitHub Bot commented on GEODE-8272:
---------------------------------------
jinmeiliao commented on a change in pull request #5249:
URL: https://github.com/apache/geode/pull/5249#discussion_r442526334
##########
File path:
geode-management/src/main/java/org/apache/geode/management/runtime/RestoreRedundancyResults.java
##########
@@ -18,28 +18,28 @@
import java.util.List;
import java.util.Map;
+import org.apache.geode.annotations.Experimental;
+
/**
* A class to collect the results of restore redundancy operations for one or
more regions and
* determine the success of failure of the operation.
*/
+@Experimental
public interface RestoreRedundancyResults extends OperationResult {
/**
* {@link #SUCCESS} is defined as every included region having fully
satisfied redundancy.
* {@link #FAILURE} is defined as at least one region that is configured to
have redundant copies
* having fewer than its configured number of redundant copies.
- * {@link #ERROR} is for cases when the restore redundancy operation was
unable to begin or threw
- * an exception.
*/
enum Status {
SUCCESS,
- FAILURE,
- ERROR
Review comment:
@DonalEvans Please take a look at this change. We get rid of the ERROR
status here because we found it's never used. No one is able to set the status
to that state, and the getter of it would only return either SUCCESS or
FAILURE. Even on develop branch, this state seems unreachable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor GFSH Restore Redundancy Command code to allow for REST API
> -------------------------------------------------------------------
>
> Key: GEODE-8272
> URL: https://issues.apache.org/jira/browse/GEODE-8272
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Mark Hanson
> Assignee: Mark Hanson
> Priority: Major
>
> Refactor GFSH Restore Redundancy Command code to allow for REST API
>
> The core code path is specific to GFSH right now and needs a few changes to
> support the REST API command.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
