[
https://issues.apache.org/jira/browse/GEODE-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139939#comment-17139939
]
ASF GitHub Bot commented on GEODE-8240:
---------------------------------------
Bill commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r442452067
##########
File path:
geode-serialization/src/main/java/org/apache/geode/internal/serialization/Version.java
##########
@@ -635,48 +569,4 @@ public boolean isPre65() {
.collect(Collectors.toList());
}
- public boolean isCurrentVersion() {
- return this.ordinal == CURRENT.ordinal;
- }
Review comment:
this was used in exactly two places and is better accomplished via
`Version.CURRENT.isEqual(someVersionOrdinal)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> View has old locator version number after rolling upgrade
> ---------------------------------------------------------
>
> Key: GEODE-8240
> URL: https://issues.apache.org/jira/browse/GEODE-8240
> Project: Geode
> Issue Type: Bug
> Components: client/server, membership
> Reporter: Ernest Burghardt
> Assignee: Bill Burcham
> Priority: Major
>
> as shown in [https://github.com/apache/geode/pull/5224]
>
> upgrade from version 1.12 doesn't seem to occur on the Locator
>
> testRollServersOnPartitionedRegion_dataserializable failure results:
> Expecting:
> <"Member Count : 3
> Name | Id
> ---- |
> -------------------------------------------------------------------------------
> vm2 | 127.0.0.1(vm2:35019:locator)<ec><v17>:41000(version:GEODE 1.12.0)
> [Coordinator]
> vm0 | 10.0.0.111(vm0:35025)<v27>:41001
> vm1 | 10.0.0.111(vm1:35030)<v29>:41002
> ">
> not to contain:
> <"1.12.0">
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
