[
https://issues.apache.org/jira/browse/GEODE-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139467#comment-17139467
]
ASF GitHub Bot commented on GEODE-8240:
---------------------------------------
Bill opened a new pull request #5273:
URL: https://github.com/apache/geode/pull/5273
[GEODE-8240](https://issues.apache.org/jira/browse/GEODE-8240)
This is an alternative solution to the one explored in
https://github.com/apache/geode/pull/5269. This PR introduces a new interface
`VersionOrdinal` to model not just versions we know about (as `Version` does)
but also future versions. Formerly Geode modeled these as `short` but that
presented difficulties in the many places where we need to compare versions. By
unifying known and unknown versions under one interface, capable of providing
generic comparison (`compareTo()`, `equals()`, and `hashCode()`) my hope is
that we can eliminate this egregious loss of information (in that other PR's
`Version` implementation):
```java
@Override
public Version getVersion() {
public Version getVersion() {
return versionObj;
try {
return Version.fromOrdinal(versionOrdinal);
} catch (final UnsupportedSerializationVersionException e) {
return Version.CURRENT;
}
```
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> View has old locator version number after rolling upgrade
> ---------------------------------------------------------
>
> Key: GEODE-8240
> URL: https://issues.apache.org/jira/browse/GEODE-8240
> Project: Geode
> Issue Type: Bug
> Components: client/server, membership
> Reporter: Ernest Burghardt
> Assignee: Bill Burcham
> Priority: Major
>
> as shown in [https://github.com/apache/geode/pull/5224]
>
> upgrade from version 1.12 doesn't seem to occur on the Locator
>
> testRollServersOnPartitionedRegion_dataserializable failure results:
> Expecting:
> <"Member Count : 3
> Name | Id
> ---- |
> -------------------------------------------------------------------------------
> vm2 | 127.0.0.1(vm2:35019:locator)<ec><v17>:41000(version:GEODE 1.12.0)
> [Coordinator]
> vm0 | 10.0.0.111(vm0:35025)<v27>:41001
> vm1 | 10.0.0.111(vm1:35030)<v29>:41002
> ">
> not to contain:
> <"1.12.0">
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
